[GitHub] cordova-lib pull request: Cb 7183

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166444947 Thanks for merging, Shazron!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: Cb 7183

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: Cb 7183

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166443467 Thanks! :) I'll review, test and pull in if all goes well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: Cb 7183

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166441171 Hi Shazron, I added a unit test that detects the security violation. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cordova-lib pull request: Cb 7183

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166405427 Got it. Sorry. I will add a unit test that detects the path escaping issue, and let you know. --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-lib pull request: Cb 7183

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166404958 I meant, you have to *add* a failing test. Your change did not include a test. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cordova-lib pull request: Cb 7183

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166404691 Hi Sharon, Thanks for reviewing. I don't see any failures for the test. {quote} [cordova-lib] node_modules/jasmine-node/bin/jasmine-node spec-plugm

[GitHub] cordova-lib pull request: Cb 7183

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166400332 Squashed all your commits and reviewed them -- seems a minimal change. I'd like to get this in, but please add a failing test first in https://github.com/apache/cor

[GitHub] cordova-lib pull request: Cb 7183

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-166394739 Hi, I'll look at this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-lib pull request: Cb 7183

Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/355#issuecomment-165621005 Hi Shazron, Could you review this CB-7183? As we discussed we need some security check for plugins accessing outside the plugins directory. Please pull

[GitHub] cordova-lib pull request: Cb 7183

GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/355 Cb 7183 CB-7183 security check for the scriptSrc property of the engine tag. The other src and target-dir path escape checks are already implemented in cordova-lib/src/plugman/pl