Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-218633214
I'd like to revive this PR. Hooks should run when using create scripts +
plugman.
---
If your project is set up for it, you can reply to this email and have yo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r62952050
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -283,7 +283,7 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugi
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-131553995
I feel like the plugman changes ( `run_hooks` ) should be part of a
separate pull request.
---
If your project is set up for it, you can reply to this email and ha
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37146091
--- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js ---
@@ -81,12 +81,6 @@ describe('HooksRunner', function() {
process.chdir(path.join(__
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37146081
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -283,7 +283,7 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37146073
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -357,7 +356,7 @@ function runInstall(actions, platform, project_dir,
plugin_dir, plugins_dir, opt
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37145990
--- Diff: cordova-lib/src/hooks/scriptsFinder.js ---
@@ -105,6 +105,11 @@ function getApplicationHookScriptsFromDir(dir) {
*/
function getScrip
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37145607
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -80,6 +96,15 @@ HooksRunner.prototype.prepareOptions = function(opts) {
return opts;
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37145507
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -60,11 +64,23 @@ HooksRunner.prototype.fire = function fire(hook, opts) {
};
/**
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-130831453
@galexandrov , will take a look when possible...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-130315580
ping @omefire
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-125530595
In our case we don't use the Cordova CLI we use cordova-{platform} scripts
for project creation and that's why we don't have the Cordova CLI Project
structure.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-122213253
What's the reason behind this proposed change ? What use case does this
fulfill ?
---
If your project is set up for it, you can reply to this email and have your
GitHub user galexandrov opened a pull request:
https://github.com/apache/cordova-lib/pull/236
Change cordova-lib to execute plugin hooks without the need of Cordova
project structure
Change cordova-lib to execute plugin hooks defined in plugin.xml without
the need of Cordova projec
14 matches
Mail list logo
