GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/182
Deprecate the old feature syntax from config.xml
Deprecates the feature syntax and starts using the new plugin tags for
defining plugins. Adjusts the tests for the new logic. The old feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/182#issuecomment-77965939
With this new syntax, how do you specify variables ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/182#issuecomment-77969729
@omefire see the changes on test-config.xml for examples of the new tag
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/182#issuecomment-77980562
ok, got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/182#issuecomment-77980572
reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26093910
--- Diff: cordova-lib/spec-cordova/ConfigParser.spec.js ---
@@ -114,78 +114,94 @@ describe('config.xml parser', function () {
expect(
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26094006
--- Diff: cordova-lib/spec-cordova/ConfigParser.spec.js ---
@@ -114,78 +114,94 @@ describe('config.xml parser', function () {
expect(
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26094288
--- Diff: cordova-lib/spec-cordova/test-config.xml ---
@@ -1,53 +1,34 @@
-
-http://www.w3.org/ns/widgets";
-xmlns:cdv = "http://cordov
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26094368
--- Diff: cordova-lib/spec-cordova/test-config.xml ---
@@ -1,53 +1,34 @@
-
-http://www.w3.org/ns/widgets";
-xmlns:cdv = "http://cordov
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26094901
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -279,113 +269,108 @@ ConfigParser.prototype = {
return scriptElements.fil
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26095241
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -279,113 +269,108 @@ ConfigParser.prototype = {
return scriptElements.fil
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26095473
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -279,113 +269,108 @@ ConfigParser.prototype = {
return scriptElements.fil
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26095614
--- Diff: cordova-lib/spec-cordova/ConfigParser.spec.js ---
@@ -114,78 +114,94 @@ describe('config.xml parser', function () {
expect(
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26095759
--- Diff: cordova-lib/spec-cordova/ConfigParser.spec.js ---
@@ -114,78 +114,94 @@ describe('config.xml parser', function () {
expect(
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26095773
--- Diff: cordova-lib/spec-cordova/ConfigParser.spec.js ---
@@ -114,78 +114,94 @@ describe('config.xml parser', function () {
expect(
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099181
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -279,113 +269,108 @@ ConfigParser.prototype = {
return scriptElements.fil
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099327
--- Diff: cordova-lib/spec-cordova/test-config.xml ---
@@ -1,53 +1,34 @@
-
-http://www.w3.org/ns/widgets";
-xmlns:cdv = "http://cordov
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099427
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -279,113 +269,108 @@ ConfigParser.prototype = {
return scriptElements.fil
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099612
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -279,113 +269,108 @@ ConfigParser.prototype = {
return scriptElements.fil
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099660
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -417,11 +402,11 @@ ConfigParser.prototype = {
getEngines: function(){
--- End d
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099684
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -257,20 +257,20 @@ function getPlatformDetailsFromDir(dir,
platformIfKnown){
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26099723
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -290,16 +290,16 @@ function remove(hooksRunner, projectRoot, targets,
opts) {
}).then(funct
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26153119
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -308,8 +301,8 @@ module.exports = function plugin(command, targets,
opts) {
};
functio
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/182#issuecomment-78261223
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user gorkem closed the pull request at:
https://github.com/apache/cordova-lib/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
25 matches
Mail list logo
