[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-06-04 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/226#issuecomment-105921556 Yeah, reworking tests will be painful. BTW, i'm still wondering that so small number of tests is became failing. --- If your project is set up for it,

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31134853 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31134829 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-26 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31049589 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** +Licensed to the Apache Software Foundation (ASF) unde

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-26 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/226#issuecomment-105573860 Looks great! Looks like figuring out the tests will be pretty difficult. But it might be worth it just throwing away some of the older tests that rely on a lot o

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-26 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31048534 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** +Licensed to the Apache Software Foundation (ASF) unde

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-25 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/226 Draft implementation for Unified platform API Draft implementation of Unified Platform API for cordova, that inspired by [this thread](http://markmail.org/thread/3dw4mis4qo5d4ecz) in c