Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191936337
@TimBarham updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54933484
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54834210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54820983
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54819210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54817429
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191504890
Okay, I added a lot of verbose logging and responded to some of the
refactor stuff @TimBarham mentioned (except where noted). I plan to rebase this
down to one comm
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54814983
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54809830
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54785237
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54772365
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54771328
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54771522
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/**
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54728499
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191259905
This is looking great **@rikroll**! I have a few comments, but mostly
pretty minor stuff.
---
If your project is set up for it, you can reply to this email and h
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727968
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727324
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727076
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54726540
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54726389
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54723579
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722281
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722165
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722073
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722038
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191085463
LGTM! Great work @riknoll! Very clean code and is easy to follow. Looking
forward to switching over to this.
---
If your project is set up for it, you can reply
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54684112
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54663442
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54660579
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190708358
LGTM apart from a couple of nitpicks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54558329
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts) {
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54558183
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts) {
});
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190569199
@TimBarham @vladimir-kotikov Can you please take a look in the next couple
of days? It will be good to get this committed and do a release.
---
If your project is
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190482871
Alright, this should be ready for review. The changes I just pushed
included a few fixes to edge cases, better handling of malformed
input/whitespace, and a lot mor
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190331301
I have significant changes to push in response to some feedback, so don't
review yet. I'll comment when they're in.
---
If your project is set up for it, you can r
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190330639
@vladimir-kotikov to also take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54193600
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +535,175 @@ function versionString(version) {
return null;
}
+
+/**
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-188462559
@TimBarham could you take a quick look at the updates when you get a chance?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-188425964
After conversation with @nikhilkh, I reworked the code a bit so that the
warnings it prints are more actionable. They now list what dependencies failed
for the late
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-187874856
Fixed jasmine tests and created a JIRA for this
([CB-10679](https://issues.apache.org/jira/browse/CB-10679))
---
If your project is set up for it, you can reply to
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53838895
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,22 @@ function listPlatforms(project_dir) {
});
}
+function getInstal
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-187701057
Other than one small remaining question, looks great! Thanks @riknoll!
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53779104
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,22 @@ function listPlatforms(project_dir) {
});
}
+function getInst
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-186466203
@TimBarham addressed your other feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53536875
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53529433
--- Diff: cordova-lib/spec-cordova/plugin_fetch.spec.js ---
@@ -0,0 +1,203 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53529097
--- Diff: cordova-lib/spec-cordova/plugin_fetch.spec.js ---
@@ -0,0 +1,203 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under on
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-186387095
Rebased to master (that was fun)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-186352413
Responded to most the feedback. Also added warnings and verbose logging
which I completely forgot in my original PR. I will rebase this branch soon
---
If your pro
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-185850104
@TimBarham thanks for the review; I'll update the PR in a bit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53358585
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/**
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305903
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305804
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305710
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305319
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304887
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304649
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53302711
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301932
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301382
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300652
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300300
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300134
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53299072
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298695
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function getInst
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298645
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function getInst
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53297519
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -492,17 +492,13 @@ function list(hooksRunner, projectRoot, opts) {
var platforms_on_fs = c
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-183479340
Rebased to master and responded to PR feedback. @TimBarham
@vladimir-kotikov can you take a look at this as well?
---
If your project is set up for it, you can rep
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-179554892
@stevengill just checking in now that Cordova 6.0.0 is released. Let me
know if you have any feedback.
---
If your project is set up for it, you can reply to this
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r50916949
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -122,25 +123,6 @@ module.exports = function plugin(command, targets,
opts) {
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r50916728
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -440,6 +451,13 @@ function list(projectRoot, hooksRunner, opts) {
});
}
+functi
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r50916413
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +525,117 @@ function versionString(version) {
return null;
}
+
+/**
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r50916227
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -440,6 +451,13 @@ function list(projectRoot, hooksRunner, opts) {
});
}
+funct
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r50916134
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -122,25 +123,6 @@ module.exports = function plugin(command, targets,
opts) {
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-174261045
Hey @riknoll,
Thanks for doing this! I'll review it after the cordova 6 release.
---
If your project is set up for it, you can reply to this email and h
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/363
New plugin version selection implementation
@stevengill @dblotsky please review. This is an implementation for the
plugin version selection scheme that Dmitry and I proposed in [this discuss
P
77 matches
Mail list logo
