Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/327#issuecomment-149737583
Thanks for taking a look, @vladimir-kotikov.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/327#issuecomment-149728218
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42565419
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42565322
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42564896
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42564428
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42562761
--- Diff: cordova-serve/src/browser.js ---
@@ -17,9 +17,15 @@
under the License.
*/
-var exec = require('./exec'),
+var child_
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42561832
--- Diff: cordova-serve/src/browser.js ---
@@ -72,7 +79,10 @@ module.exports = function (opts) {
args.push(url);
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42561198
--- Diff: cordova-serve/src/browser.js ---
@@ -17,9 +17,15 @@
under the License.
*/
-var exec = require('./exec'),
+var
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/327
On Windows, verify browsers installed before launching.
Do this to avoid dialog that pops up on Windows if browser is not
installed, and provide more meaningful error messages.
You can merge
11 matches
Mail list logo
