[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/314#discussion_r41439142 --- Diff: cordova-serve/src/server.js --- @@ -17,121 +17,51 @@ under the License. */ -var chalk = require('chalk'), -fs

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-146290411 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/314#discussion_r41429108 --- Diff: cordova-serve/src/server.js --- @@ -17,121 +17,51 @@ under the License. */ -var chalk = require('chalk'), -fs

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/314#discussion_r41426471 --- Diff: cordova-serve/serve.js --- @@ -17,9 +17,41 @@ under the License. */ -module.exports = { -sendStream: require('./sr

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145742256 No problem :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145741933 Great, thanks. I love express, just wanted to be sure. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145741275 It only impacts the `cordova run browser` command (which already runs on a local node server) - it has no impact on how users might deploy their app when targetin

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145737064 How does this impact the cordova-browser platform? Do browser targeting apps now depend on express and node on the server? Or can they be deployed as static s

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/314 Refactor cordova-serve to use Express. This simplifies a lot of code, but more importantly provides a more standardized and modular way to customize the server (via Express middleware).