[GitHub] cordova-lib pull request: Update hooks-README.md

2014-06-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: Update hooks-README.md

2014-06-13 Thread 16BITBoy
Github user 16BITBoy commented on the pull request: https://github.com/apache/cordova-lib/pull/28#issuecomment-46031100 Ok, I've fixed the typo, also rephrased the sentence inside the brackets, and removed the redundant one. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: Update hooks-README.md

2014-06-13 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/28#discussion_r13758029 --- Diff: cordova-lib/templates/hooks-README.md --- @@ -81,3 +80,7 @@ cross-platform. Some good examples are shown here: [http://devgirl.org/201

[GitHub] cordova-lib pull request: Update hooks-README.md

2014-06-13 Thread 16BITBoy
GitHub user 16BITBoy opened a pull request: https://github.com/apache/cordova-lib/pull/28 Update hooks-README.md I think letting know to users of Windows that a shebang line is expected at the start of their non bat scripts is a good idea, since its not typical for Windows users to