[GitHub] cordova-lib pull request: add missing package_suffix function on a...

2015-11-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: add missing package_suffix function on a...

2015-11-15 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/343#issuecomment-156878470 I think the reason why that function is needed is because of this:

[GitHub] cordova-lib pull request: add missing package_suffix function on a...

2015-11-15 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/343#issuecomment-156878477 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: add missing package_suffix function on a...

2015-11-14 Thread paulhovey
GitHub user paulhovey opened a pull request: https://github.com/apache/cordova-lib/pull/343 add missing package_suffix function on amazon-fireos platform for plu… This came about while trying to install https://github.com/katzer/cordova-plugin-badge to an amazon-fireos platform.