[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-23 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241 Yes, makes sense. Icon management needs more tweaks, but this way it will work better already Thanks for the review. --- If your project is set up

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-23 Thread tsschaffert
Github user tsschaffert commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142535031 Shouldn't this be handled similar to how it is done in the manifest generation of cordova-ubuntu? Then the 'www' part should be replaced by '../..' (otherwise

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-07 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/299 icon parameter should not be relative to the www directory on Ubuntu You can merge this pull request into a Git repository by running: $ git pull