[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67084182 --- Diff: cordova-lib/src/cordova/create.js --- @@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, fetchOpt) {

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user carynbear commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077463 --- Diff: cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt --- @@ -0,0 +1 @@ +blah --- End diff --

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user carynbear commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077366 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -121,6 +122,36 @@ describe('create end-to-end', function() { // expect(configXml.n

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077184 --- Diff: cordova-lib/src/cordova/create.js --- @@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, fetchOpt) {

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67073107 --- Diff: cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt --- @@ -0,0 +1 @@ +blah --- End diff --

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67071311 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -121,6 +122,36 @@ describe('create end-to-end', function() { // expect(configXml.

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67070160 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -38,15 +37,17 @@ var configNormal = { version: 'testCordovaCreate'

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

GitHub user carynbear reopened a pull request: https://github.com/apache/cordova-lib/pull/456 CB-11412 improve template implementation Removed symlinking. You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-lib CB-11

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

Github user carynbear closed the pull request at: https://github.com/apache/cordova-lib/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/456 CB-11412 improve template implementation Removed symlinking. You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-lib CB-1141