Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102321817
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102099272
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877578
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877994
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101875939
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -388,26 +384,54 @@ module.exports = function plugin(command, targets,
opts) {
function de
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101873081
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -353,4 +353,5 @@ describe('plugin add and rm end-to-end --fetch',
function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101872753
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -253,6 +275,7 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101873667
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -742,7 +742,7 @@ describe('update config.xml to use the variable found
in pkg.json'
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101870795
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -388,26 +384,54 @@ module.exports = function plugin(command, targets,
opts) {
function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101826675
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -69,7 +71,7 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
options
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/518
CB-12021 : --fetch should use dependency version saved in package.json
before default cordova version when adding/restoring
### Platforms affected
### What does this PR
12 matches
Mail list logo
