[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-21 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/94#issuecomment-213118959 Related PR: https://github.com/apache/cordova-medic/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-20 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/94#discussion_r60492470 --- Diff: lib/util.js --- @@ -74,24 +81,95 @@ module.exports = (function () { return numDevices; } +function getSim

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-20 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/94#issuecomment-212592382 Rebased on top of master and ready to be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/94#discussion_r60300760 --- Diff: lib/medicPermissions.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path= require('path');

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/94#discussion_r60300110 --- Diff: lib/medicPermissions.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path= require('path');

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/94#issuecomment-212074252 @sarangan12 could you please review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/94#issuecomment-212074104 This PR ports part of the following paramedic PR to medic: https://github.com/apache/cordova-paramedic/pull/4 --- If your project is set up for it, you can rep

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-medic/pull/94 CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions while… … running on iOS simulator You can merge this pull request into a Git repository by running: $ git pull https://