[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70712736 Oh, ok. Nice catch. Do you think we should submit a fix? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-20 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70627597 I've played with it for some time and found that `pending()` actually throws an exception that must be handled by Jasmine and spec should terminate. In thi

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70544816 Ah, that makes sense. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-19 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70473211 It looks like Jasmine executes pending specs anyway, it just don't mark them red if they fail. --- If your project is set up for it, you can reply to this

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70349610 On OSX, everything is green. On Windows, everything except Whitelist is green. On Whitelist I'm seeing an error, `... encountered a declaration exception` f

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-16 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70258752 I've rebased this. No error for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-69891183 I currently get a `Missing semicolon.` error in `src/android/exec.js` when I run createmobilespec. This may be fixed in the latest version: please merge wit

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2014-12-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#discussion_r21577291 --- Diff: cordova-plugin-mobilespec-tests/tests/localXHR.tests.js --- @@ -0,0 +1,206 @@ +/* +* +* Licensed to the Apache

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2014-12-05 Thread MariaBukharina
GitHub user MariaBukharina opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/113 CB-8131 Rewrote non plugin auto tests for Jasmine 2.0 https://issues.apache.org/jira/browse/CB-8131 You can merge this pull request into a Git repository by running: $ git p