[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-83116032 Tested on my end. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-18 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82833050 @dblotsky Ah, it couldn't locate mobilespec tests, thanks for pointing that out! Fixed it. --- If your project is set up for it, you can reply to this

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82510437 This fails to get tests when `--plugins` is specified. Also, this is a major breaking change to any tool or person that depends on modifying the dependencie

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82486029 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/123 CB-8694 Replaced dependencies plugin with command line parameter https://issues.apache.org/jira/browse/CB-8694 You can merge this pull request into a Git repository by running: $