[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-11 Thread ktop
Github user ktop closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100331095 I done goofed and forgot to say "This closes #124". Merged though. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100330631 Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100326111 yes. I believe that was the intent, although it obviously failed. This is an easy merge. +1 --- If your project is set up for it, you can reply t

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100325757 Oh, so it's mostly a convenience for a human tester? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100323303 I think it was to make sure the most recent additions were seen. Seems someone magically assumed it would always be less than 2 lines. --- If y

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100322451 What was the purpose of the call before? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread ktop
Github user ktop commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100264782 Can someone take a look at this? I think it should be a simple merge --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-03-21 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/124 CB-8727 Fix failing WebSQL test on Android 5.1 - scrollByLines is an unknown function in Android 5.1 - removed because it causes the exception and does not affect the test itself You