Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Merged! Thanks again @swbradshaw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Cordova CI Build has completed successfully.
**Commit** -
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@swbradshaw don't worry about it! We all make mistakes like that.
Really appreciate the PR! I'll test and merge it in tomorrow.
Thanks!
---
If your project is
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@stevengill Man, I'm such an amateur. Removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@swbradshaw looks you included a new file named `CameraLauncherMaster.java`
in your commit by mistake
---
If your project is set up for it, you can reply to this email and have
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Cordova CI Build has completed successfully.
**Commit** -
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@stevengill - I think this is good to go. My first PR/rebase, hopefully
didn't messed it up!
-Rebased from master
-Verified rotation is working correctly after merge
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Sounds good @swbradshaw. It looks like
https://github.com/apache/cordova-plugin-camera/commit/fed798e6c7f56e23bff994ab2c11d316c8257a78
created some conflicts. I'll hold off on the
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@stevengill ill take a look this weekend. This is my first PR/rebase so
I've got some homework to do
---
If your project is set up for it, you can reply to this email and have
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@swbradshaw any chance you can deal with the merge conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Hey! Just reviewed this and it looks good to me.
Can you do one final rebase from master and I'll merge it in?
---
If your project is set up for it, you can reply to this
Github user adamscybot commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Should add we have tested this fixed pull request in production and its
working for us.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user adamscybot commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
Most positive changes to cordova never seem to get merged because of
pending tests. Ultimately functionality on popular core plugins is just broken
because of this.
---
If your
Github user riknoll commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@swbradshaw I apologize, I have not had a chance to test this out and I am
not likely to anytime soon. Sorry, I should have left a comment
---
If your project is set up for it, you
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@riknoll Have you had a chance to test these changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
15 matches
Mail list logo
