Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/244/commits/05594c46468576da846b31b03e624d72f7c9c47
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Rebased and squashed commit and updated message to have the same format as
you pointed out @alsorokin. Thanks for the review! I'll merge upon tests
passing.
---
If your project is set
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Filed [CB-12312](https://issues.apache.org/jira/browse/CB-12312) for this
one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Nit: it would be nice if first two checklist items would be fulfilled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/244/commits/4e26e2a04ae256e4305419a9d469771dd4e0f8c
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
@alsorokin thanks for the feedback, I've addressed your points. Let me know
if you have any other concerns or if you are good with merging it.
---
If your project is set up for it, you
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Oh! I totally forgot to ping @alsorokin for a review :)
If you find the time, please review good sir!
---
If your project is set up for it, you can reply to this email and have
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/244
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/244/commits/f4616d88cd1b87433f0f8b98a1d228253be461a
