Github user sencenan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161523938
Making a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user sencenan closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161447751
@sencenan Sure, go ahead and submit a new PR. Tag both JIRA's in the commit
message (CB-10093 and CB-9960) if you don't mind.
---
If your project is set
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161393743
Just make sure your name is on your github profile, which it appears to be.
:+1:
We just needed the name at https://github.com/sencenan to also
Github user sencenan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161390659
How would I associate my full name with my github id? I also fixed the
problem with Google Photos which touches the same area of code. Should I remove
t
Github user sencenan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161089732
ICLA signed and mailed to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user sencenan commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#discussion_r46334032
--- Diff: src/android/FileHelper.java ---
@@ -79,30 +79,59 @@ public static String getRealPath(String uriString,
CordovaInterface cordova) {
Github user sencenan commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#discussion_r46334003
--- Diff: src/android/FileHelper.java ---
@@ -79,30 +79,59 @@ public static String getRealPath(String uriString,
CordovaInterface cordova) {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161049522
Thanks! LGTM as well; I just wanted to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161047893
LGTM! @riknoll I don't see anything than formatting changes done to the
ContentResolver, and this actually might fix a bug for the Camera as well,
which
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#discussion_r46312808
--- Diff: src/android/FileHelper.java ---
@@ -79,30 +79,59 @@ public static String getRealPath(String uriString,
CordovaInterface cordova) {
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#discussion_r46312504
--- Diff: src/android/FileHelper.java ---
@@ -79,30 +79,59 @@ public static String getRealPath(String uriString,
CordovaInterface cordova) {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161046152
Thanks! I can reproduce this (I used Marshmallow, but same difference). I
also believe this is indeed a distinct issue from CB-9960. @infil00p would you
Github user sencenan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161008858
Hi, I will get the CLA signed later today when i have some time.
For step to reproduce try this:
- device: android 5.1
- use cordova
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-160816613
Also, I don't see your name [in the CLA
list](https://people.apache.org/committer-index.html#unlistedclas). For this to
be eligible to be merged in, you'
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-160815988
Thanks for the PR!
Can you provide the exact camera options you are testing with so that I can
try this out? And when you say the gallery app, wh
16 matches
Mail list logo
