[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-11 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218547172 Thanks for the feedback! I made some updates based on feedback. As far as running tests - we're automating that process using Jenkins, Travis C

[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-10 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218282825 great points @tony-- ! +1 to all of 'em --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-10 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218277348 There are a couple places that contributor workflow is documented: The wiki has a [contributor workflow page](https://wiki.apache.org/cordova/Contribut

[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-10 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218265034 +1 to the PR title suggestion The icla is NOT actually required for smaller changes, and we should only be enforcing this for large/deep changes

[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-10 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218253991 Do we need to provide a link for CCLA info just in case? Can we also suggest a format for PR titles? Something like: ``` [CB-12345]: Short descrip

[GitHub] cordova-plugin-camera pull request: Add pull request template

2016-05-10 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/213 Add pull request template You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera pr-template Alternat