Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#issuecomment-210056156
LGTM! I'll merge this later today and regenerate the README
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59614155
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozil
Github user Mikejo5000 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59604648
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mo
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59602729
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozil
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59602299
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozil
Github user Mikejo5000 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59600615
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mo
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59477164
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozil
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59476286
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozil
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59475889
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozil
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#issuecomment-208634228
I made a few comments inline, but nothing major.
Also, `README.md` is actually a generated file in this repo (and this repo
only). It would be gr
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59302091
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59300947
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59300666
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59299069
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59298569
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59298463
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59298167
--- Diff: README.md ---
@@ -526,3 +526,207 @@ Tizen only supports a `destinationType` of
[web_activities]:
https://hacks.mozilla.org/2013
GitHub user Mikejo5000 opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/203
Added Sample section to the Camera plugin README
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mikejo5000/cordova-plugin-cam
19 matches
Mail list logo
