Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195948500
The new PR is merged. @dlogo can you close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195345471
@riknoll thanks for your work!! Don't hesitate to close this PR if a new
one is coming to solve it.
---
If your project is set up for it, you can reply to
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195335571
I'm working on a PR that will remove the whole API11to18 part, so I think
we can close this
---
If your project is set up for it, you can reply to
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195093360
I just got a Jellybean device, so I'm going to verify that there is no
issue there first
---
If your project is set up for it, you can reply to this ema
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195092845
Shall we close this PR now? :boom:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195080403
I can confirm this is no longer an issue on Marshmallow. I tested all of
the permutations of camera options with both the stock gallery app and Google
Ph
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189959679
If you could sync your code with the current code on master so the merge
conflicts dissapear it will be easier to merge
---
If your project is set
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189903116
Hi @jcesarmobile, yeah I show your code, great job! But appart from that
I've added modifcations for API11to18. I gues that someone with permissions
could
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189899283
Your code is out of sync with the current code, the whole
getRealPathFromURI_API19 method is different now, and already have code to
handle videos
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189703384
@dallas sorry for answering late, I have checked the differences between
the PR and the base and I think that merge should be done if the PR is checked
by
Github user dallas commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189430481
@dlogo & @riknoll any chance of getting this merged in today (not sure what
time zones you are all in)? I'm in US Pacific time zone and I'd love to try
th
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189215745
Hi,
@riknoll, I've implemented the requested changes and also received the ok
for the Apache ICLA register. Unfortunately I have to merge changes, I'll
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-173118941
@riknoll thanks for reviewing the code, I'll follow your recommendations
and update the code asap!
---
If your project is set up for it, you can reply to
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-173005542
@dlogo Thanks for submitting a PR! There are a number of whitespace issues
that must be resolved before this is eligible to be merged. Please make sure
y
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165780
--- Diff: src/android/FileHelper.java ---
@@ -79,50 +79,72 @@ public static String getRealPath(String uriString,
CordovaInterface cordova) {
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165621
--- Diff: src/android/FileHelper.java ---
@@ -79,50 +79,72 @@ public static String getRealPath(String uriString,
CordovaInterface cordova) {
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-172961014
This seems important enough. @riknoll can you review this? It relates to:
CB-10177
---
If your project is set up for it, you can reply to this email a
Github user TanaseButcaru commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-170388333
Really needed this one. Thanks!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user dlogo opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/149
Android FileHelper modifications to manage videos
Updated getRealPathFromUri method for APIs above 10th in order to manage
not only images but also videos. Furthermore the function for
20 matches
Mail list logo
