Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59295343
--- Diff: appium-tests/android/android.spec.js ---
@@ -27,52 +28,47 @@
'use strict';
-var wdHelper = require('../helpers/
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59190313
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -85,204 +84,187 @@ describe('Camera tests iOS.', function () {
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59189798
--- Diff: appium-tests/android/android.spec.js ---
@@ -251,141 +200,50 @@ describe('Camera tests Android.', function () {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59189329
--- Diff: appium-tests/android/android.spec.js ---
@@ -27,52 +28,47 @@
'use strict';
-var wdHelper = require('../
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#issuecomment-207332653
@riknoll addressed both of your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r58923139
--- Diff: appium-tests/android/android.spec.js ---
@@ -450,143 +306,110 @@ describe('Camera tests Android.', function () {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/202#issuecomment-207042099
I'm not sure if this is a limitation of the way appium injects functions,
but since the promise-related callbacks seem to be the same for iOS and
Android
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/202
Appium tests stability improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-camera ui-tests
