Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196590433
Alright, I resolved the conflicts but after looking at the code I want to
do another round of testing before I merge this in. This will be the first
thin
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196421118
Right, thanks @ochakov as well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196420729
@ochakov mainly! :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196420235
I will merge this today, need to resolve some merge conflicts. Thanks
@MatthewBooth!
---
If your project is set up for it, you can reply to this email a
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196225403
ICLA was filled out. Sorry for the delay, I hadn't been tracking these
comments unfortunately. It's done now, though.
---
If your project is
Github user okonon commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191558538
@riknoll got it thanks a lot. Fingers crossed. hopefully he will do it soon
---
If your project is set up for it, you can reply to this email and have you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191549054
There were conflicts that he resolved, so yes I do need an ICLA
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user okonon commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191394465
@riknoll what in particular the ICLA for this PR? For the fact that
@MatthewBooth rebased someone else's commits? If yes, can someone more
responsive crea
Github user okonon commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-191289031
@riknoll there are multiple PRs related to this issue. @MatthewBooth can
you please fill out needed documentation?
---
If your project is set up for it,
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-189490623
@MatthewBooth I want to merge this in. Have you filed an ICLA? See the
prerequisites here:
http://cordova.apache.org/contribute/contribute_guidelines.htm
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/179
CB-10120 android: Camera permission must be requested when present in
Manifest
Because three PRs are better than one.
This provides fixes for #142 and is based on top of the
12 matches
Mail list logo
