Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171394616
Also tested mobilespec manual tests on a lollipop emulator with
cordova-android's master and cordova-android 4.0.0. Again, only expected
failures. I'm go
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171382725
Tested with manual mobilespec tests on cordova-android's master and
cordova-android 4.0.0 on a marshmallow device. The failures in those tests
matched th
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171126273
I updated/rebased the commit to remove the imports @jasongin mentioned
---
If your project is set up for it, you can reply to this email and have your
re
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#discussion_r49501759
--- Diff: src/android/CameraLauncher.java ---
@@ -26,11 +26,14 @@ Licensed to the Apache Software Foundation (ASF) under
one
import java.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171023560
Just for context, Here's the link to the related mailing list discussion:
http://apache.markmail.org/message/bwhpuh7m6fyf5eem?q=Richard+Knoll+%5BDISCUSS%5
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171018798
LGTM, aside from the one minor issue I commented about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#discussion_r49497844
--- Diff: src/android/CameraLauncher.java ---
@@ -26,11 +26,14 @@ Licensed to the Apache Software Foundation (ASF) under
one
import java
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-170647098
@infil00p @jasongin please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/151
CB-10319 android: Adding reflective helper methods for permission requests
As discussed on the mailing list
You can merge this pull request into a Git repository by running:
$ gi
10 matches
Mail list logo
