[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-21 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/195#issuecomment-199205326 > It might make life easier to put these guys in a loop. @dblotsky, I believe the whole tests file should be updated in this case and propose to

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/195#issuecomment-197422268 LGTM. Thanks for improving testing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/195#discussion_r56371109 --- Diff: tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m --- @@ -304,24 +303,28 @@ - (void) testImageScaleNoCropForSize {

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/195 CB-10865 Run ios native tests on Travis Fixed tests project build failure. Updated cordova-ios tests dependency version to latest published. [Jira issue](https://issues.ap