[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-08-03 Thread muratsu
Github user muratsu closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-30 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/110#issuecomment-126443320 I think the logic has to stay in onClick event for easy cleanup purposes. I've made the event handlers seperate functions. It's much cleaner now. --- I

[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/110#issuecomment-125397586 This seems to work, but perhaps removing the listener on the first call would be a better approach. Also, I assume I can button mash the cancel

[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-27 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/110 CB-9151 Trigger captureAction only once Prevent multiple captureAction calls by using `clicked` attribute You can merge this pull request into a Git repository by running: $ git