Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-201945371
@infil00p Should we close this PR? After thinking about this for quite some
time, I think fixing https://issues.apache.org/jira/browse/CB-9506 would be
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150748364
@infil00p Yes, it would still have the problem. I submitted this fix still
because it is trivial (this PR won't change how the plugin is used at all, and
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150703173
@cojomojo Won't this still have the problem you found when you filed this?
https://issues.apache.org/jira/browse/CB-9506
---
If your project is set up
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147473478
@sgrebnov @vladimir-kotikov OK, I fixed the issue caused by a bad merge.
This PR is ready once we see how @infil00p 's PR for Cordova-Android 5.0.x and
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147443350
@infil00p Good idea, let me know when it's merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147443002
Can this wait until after my Cordova-Android 5.0.x pull request is merged
in? checkForDuplicateImage requires a permission on Android 6.0+ and I want to
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147434553
@sgrebnov Something got messed up when I merged in the latest before
resubmitting. I doubt this is even valid Java right now, I'll fix it later
today an
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147357893
Reviewed: :+1: thank you @cojomojo!
@vladimir-kotikov, I know that you are working on some other improvements
so please merge this along with your wo
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#discussion_r41742198
--- Diff: src/android/CameraLauncher.java ---
@@ -386,12 +387,10 @@ private void processResultFromCamera(int destType,
Intent intent) throws
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#discussion_r41742092
--- Diff: src/android/CameraLauncher.java ---
@@ -241,6 +241,7 @@ public void takePicture(int returnType, int
encodingType) {
* @re
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147061485
@sgrebnov Ok, I finally got around to doing what you suggested. Please
re-review.
---
If your project is set up for it, you can reply to this email and
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#discussion_r39375449
--- Diff: src/android/CameraLauncher.java ---
@@ -983,12 +983,39 @@ private Cursor queryImgDB(Uri contentStore) {
* @param newImage
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-140016250
@cojomojo the fix makes perfect sense, but I see that the code you use is
very similar to what we have in `checkForDuplicateImage` and looks like that
f
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-139374302
@sgrebnov to see if you can help merge this. Do we have the correct test
coverage for this?
---
If your project is set up for it, you can reply to this
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-137577342
Is this PR still being considered?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-133206691
Fixed the PR to only affect the cleanup function. Please re review.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user cojomojo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-133204027
That was not suppose to be removed, must have done that accidentally. Ill
fix it, and update the PR in a few minutes.
---
If your project is set up for
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-133185529
You removed part of the cropping functionality, we can't accept this pull
request as it is.
---
If your project is set up for it, you can reply to this
GitHub user cojomojo opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/115
CB-9490 Fixed cleanup function
Modfied cleanup function to deal with camera applications that save photos
that should have been discarded when the retake option was chosen
You can m
19 matches
Mail list logo
