[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2016-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2015-07-13 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/14#issuecomment-121085416 @dylanrynhart ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2015-03-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/14#issuecomment-77971405 Merge conflicts, please rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2015-01-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/14#issuecomment-69425093 My apologies, the code has been refactored to be testable, so it doesn't merge cleanly anymore. It should be an easy rebase from your patch (I hope). ---

[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2014-08-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/14#issuecomment-52080760 @dylanrynhart please see: http://wiki.apache.org/cordova/ContributorWorkflow (ICLA) http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira;

[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2014-08-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/14#discussion_r16190380 --- Diff: src/ios/CDVCamera.m --- @@ -736,21 +736,4 @@ @implementation CDVCameraPicker @synthesize webView; @synthesize popoverSupported

[GitHub] cordova-plugin-camera pull request: Correcting errors with present...

2014-06-27 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/14#discussion_r14304481 --- Diff: src/ios/CDVCamera.m --- @@ -736,21 +736,4 @@ @implementation CDVCameraPicker @synthesize webView; @synthesize popoverSupporte