Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190840500
Oops, my bad. :)
Reviewing that PR instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190836981
@omefire I did close this one :wink:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190836679
I see that you opened another PR:
https://github.com/apache/cordova-plugin-camera/pull/185
Please, close this one then.
---
If your project is set
Github user dieppe closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190409102
just started reviewing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user adamscybot commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190153265
With a project as popular as cordova is -- its so disappointing to see most
of the "official" plugins are bug ridden and feel abandoned.
---
If your
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-155457722
Very disappointed to see that our efforts have been completely overlooked.
This PR actually fixes a bunch of bugs that have since been fixed, and
Github user athibaud commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-122946563
:wave:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-115352285
@shazron Any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-109964558
The most probable is that it is a side effect, since I did not touch the
implementation of `imageByScalingNotCroppingForSize` one bit :wink:
---
If
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-109397387
This is amazing, thank you for this.
This seems to fix: https://issues.apache.org/jira/browse/CB-5942 although
I'm not sure how exactly (side
GitHub user dieppe opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/101
Major refactor
Hi there,
We needed access to the metadata which lead to asynchronous operations. We
took the opportunity to refactor most of the plugin logic. Hopefully it's
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/96
major refactor : readability
aliased lots of the super long namespaces so we aren't fighting past with
the 100 char line.
You can merge this pull request into a Git repository
13 matches
Mail list logo
