Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-148683134
The issue is fixed now in
https://github.com/apache/cordova-plugin-camera/pull/122 This PR seems not
actual anymore.
---
If your project is set
Github user jhurliman commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103265287
My apologies, I'm not doing active development with Cordova at the moment
and don't have time to setup a dev environment to work on this. Can someone
pl
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103238194
bump
Any update on this? Running into issues because of it. Thanks
---
If your project is set up for it, you can reply to this email and have yo
Github user boboldehampsink commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-73113534
Any news on this? This has been bugging me for a while
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-69425056
My apologies, the code has been refactored to be testable, so it doesn't
merge cleanly anymore. It should be an easy rebase from your patch (I hope).
---
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-52080044
@jhurliman: could you please update this PR (squish the commits, change the
commit message to match jira issue)?
http://wiki.apache.org/cordova/Issu
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-47380724
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091967
Found the culprit:
https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L312
If e
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091677
After debugging, there are two spots that are not handled:
1.
https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091340
How are you testing this? My device is non-responsive when I integrated
your code and do:
```
navigator.camera.getPicture(onSuccess, onFail, { quali
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42090217
Filed https://issues.apache.org/jira/browse/CB-6627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jhurliman commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-40953964
@shazron pull request updated and CLA submitted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-40951040
Thanks for this pull request. However, I have one comment, you need to use
a weak reference to self in the block. See:
1.
https://github.com/apach
GitHub user jhurliman opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/20
Make dest NATIVE_URI compatible with source CAMERA
When using the camera in iOS, UIImagePickerControllerReferenceURL does not
exist because the image only exists in memory immediatel
15 matches
Mail list logo