[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-10-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-148683134 The issue is fixed now in https://github.com/apache/cordova-plugin-camera/pull/122 This PR seems not actual anymore. --- If your project is set

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-05-18 Thread jhurliman
Github user jhurliman commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103265287 My apologies, I'm not doing active development with Cordova at the moment and don't have time to setup a dev environment to work on this. Can someone pl

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-05-18 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103238194 bump Any update on this? Running into issues because of it. Thanks --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-02-05 Thread boboldehampsink
Github user boboldehampsink commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-73113534 Any news on this? This has been bugging me for a while --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-01-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-69425056 My apologies, the code has been refactored to be testable, so it doesn't merge cleanly anymore. It should be an easy rebase from your patch (I hope). ---

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-08-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-52080044 @jhurliman: could you please update this PR (squish the commits, change the commit message to match jira issue)? http://wiki.apache.org/cordova/Issu

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-06-27 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-47380724 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091967 Found the culprit: https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L312 If e

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091677 After debugging, there are two spots that are not handled: 1. https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091340 How are you testing this? My device is non-responsive when I integrated your code and do: ``` navigator.camera.getPicture(onSuccess, onFail, { quali

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42090217 Filed https://issues.apache.org/jira/browse/CB-6627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-04-21 Thread jhurliman
Github user jhurliman commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-40953964 @shazron pull request updated and CLA submitted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-04-21 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-40951040 Thanks for this pull request. However, I have one comment, you need to use a weak reference to self in the block. See: 1. https://github.com/apach

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-03-29 Thread jhurliman
GitHub user jhurliman opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/20 Make dest NATIVE_URI compatible with source CAMERA When using the camera in iOS, UIImagePickerControllerReferenceURL does not exist because the image only exists in memory immediatel