Github user FuzzyTree commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-176045492
Debugging shows that `FileHelper.getRealPath` returns an empty (non-null)
string, which causes the function to return a directory name instead of a file
Github user nantunes commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-172819385
_Per se_ the patch only manipulates strings:
```java
String fileName = realPath != null ?
realPath.substring(realPath.lastIndexOf('/') + 1)
Github user FuzzyTree commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-172693987
Has anyone tested this patch? Applying the changes to CameraLauncher.java
results in failed `getPicture` calls. Unfortunately the only error is "Error
r
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-148681683
Yep, see it now. Merging. Thanks for contribution, @nantunes!
---
If your project is set up for it, you can reply to this email and have your
rep
Github user nantunes commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-148242066
Rebased and ICLA sent by email.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#discussion_r42041652
--- Diff: src/android/CameraLauncher.java ---
@@ -498,15 +498,19 @@ private void refreshGallery(Uri contentUri)
private
Github user nantunes commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-148098530
Ok, will do it this night.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user nantunes commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#discussion_r42013268
--- Diff: src/android/CameraLauncher.java ---
@@ -498,15 +498,19 @@ private void refreshGallery(Uri contentUri)
private String
Github user nantunes commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#discussion_r42013118
--- Diff: src/android/CameraLauncher.java ---
@@ -498,15 +498,19 @@ private void refreshGallery(Uri contentUri)
private String
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-148086313
@nantunes, thanks for contribution. Could you please rebase your changes.
Also please file an Apache CLA as described in
[CONTRIBUTING.md
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#discussion_r42008744
--- Diff: src/android/CameraLauncher.java ---
@@ -498,15 +498,19 @@ private void refreshGallery(Uri contentUri)
private
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#discussion_r42008539
--- Diff: src/android/CameraLauncher.java ---
@@ -498,15 +498,19 @@ private void refreshGallery(Uri contentUri)
private
Github user schreyers commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-132121816
Sorry for the delayed reply. Have been trying to build locally but i get
loads of errors.
I really need this to be fixed in the npm version of
Github user nantunes commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-129946137
I'm using the lastest versions of cordova with ionic framework. I build
locally. No phonegap-build, so I can't tell.
---
If your project is set up for i
Github user schreyers commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-129353345
Hi @nantunes
Quick question. Are you able to use your forked version when using
build.phonegap.com? If not how are you using your changes?
Github user schreyers commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-127647097
Thanks @nantunes
I'll make your changes to the files and remove the source="npm" from my
config file.
---
If your project is set up for it, y
Github user nantunes commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-127643570
Hi @schreyers
I'm still using my forked version, as this PR hasn't been merged (or even
reviewed).
If it is critical to your project, y
Github user schreyers commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-127485107
Hi Nantunes,
Did you manage to use the realpath filename and if so which version of the
plugin is it in is this in? There is a current bug whic
GitHub user nantunes opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/99
Try to use realpath filename instead of default modified.jpg
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nantunes/cordova-plu
20 matches
Mail list logo
