Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156984521
OK, just started a [discussion
thread](http://callback.markmail.org/thread/5bjkv4ukymo6ybot).
---
If your project is set up for it, you can reply
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156988289
@riknoll:
> in general we try to be extra careful when we add platform-specific
options to plugins
another reason, we did this pull
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156374999
Yes, of course I did read that, too â but (excerpt from the excerpt
:wink:):
> ⦠to cover any of their contributions which are not owned by
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156375961
Yeah, that's a legal thing so it could be interpreted differently.
I'm not a lawyer so not sure, probably someone from the community could
help to
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156369410
Not sure if only CCLA is needed:
> For a corporation that has assigned employees to work on an Apache
project, a Corporate CLA (CCLA) is
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156366234
Yesterday my boss obviously sent a CCLA, 'cause he forwarded to me a mail
from Craig L Russel, which acknowledges it's receipt.
As there's just a
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156454285
@convey-mane, I believe you should do the following with the PR:
- Send a message to the [dev-list](http://cordova.apache.org/contact/) with
the
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156442350
@daserge: today the admin of our GitHub enterprise account was here, he
looked at my posting from yesterday concerning `rebase` (you remember?); his
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156036480
OK, back again (and after reading a lot about `rebase` :wink:);
maybe first things first â¦
@daserge to your suggested `rebase`,
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156117731
@jcesarmobile when you write "_we should discuss_" ⦠do you mean you
"Apaches"?
Or should I participate? Stand up for my commits, argue for
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156125124
(no time left today for an answer to @riknoll ⦠cu tomorrow)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156130089
When I say we I mean everybody, it's open source ;)
Start by sending an email to dev@cordova.apache.org proposing this new
feature, so
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156178706
By quirk, we mean that in general we try to be extra careful when we add
platform-specific options to plugins. That's not to say that this is not a good
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-154495633
There are a number of JIRAs that are unhappy with the native iOS crop
(CB-9930, CB-2648), but I agree that this needs to be discussed on the mailing
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153756910
I think we should discuss this change before merging, it's a big change and
add an ios "quirk". We recently rejected another pull request that was
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153758198
Yep, I just wanted to clarify on the docs-gen-related things.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153722564
@convey-mane, You are contributing a significant change, so an ICLA/CCLA
need to be signed as well: http://www.apache.org/licenses/#clas
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153718521
OK with that `npm run gen-docs` the README.me now again is identical to
before your first comment :wink: but nevertheless learned something new.
Github user convey-mane commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153643852
So ⦠just to get it right ⦠please forgive any "newbie"-questions:
I went to my local GitHub-directory, there into the camera-repository,
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153645252
@convey-mane, that's right, just run `npm run gen-docs` after that.
I'm going to merge in #133 soon, please rebase on it after the merge;
the PR
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153646878
Merged #133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-152931387
@convey-mane, thanks for the contribution!
Regarding the docs part - you should move the addition to
jsdoc2md/TEMPLATE.md under [`camera.getPicture
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-152943467
> the many changes without real changes in README.md â obviously there
were different line-endings here and there :disappointed:;
Yes, there
GitHub user convey-mane opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/131
iOS: new resizable cropping rectangle instead of Apple's standard square
The title and comment of commit
24 matches
Mail list logo
