Github user mad-nuts commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
@filmaj I haven' t signed the Apache ICLA yet. I'll have a look into it (as
well as the rebase & force-push) within the next few days and if I'm
comfortable with it and it doesn't
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
Oh, and @mad-nuts have you signed an Apache ICLA? (individual contributor
license agreement)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
Thanks for the review @infil00p !
@mad-nuts can you do me a favour and rebase w/ the latest master and
force-push up to your branch, for one more CI / cordova-qa run, please?
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
Honestly, the Contacts API on Android itself is buggy and unpredictable.
Just run adb logcat without debugging anything and you'll see a stack trace
from Facebook, Twitter,
Github user mad-nuts commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
I've tried for hours to reproduce the error, but the app just won't crash
anymore.
Something must have changed since then and I don't know what it is...
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
It _does_ look like [iOS returns label
information](https://github.com/apache/cordova-plugin-contacts/blob/master/src/ios/CDVContact.h#L92)
in contacts, so there is precedent to
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
Cordova CI Build has completed successfully.
**Commit** -
