[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...

2014-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...

2014-08-15 Thread mmocny
Github user mmocny commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/41#issuecomment-52351394 Looks good, but I didn't test on windows. Additionally, we should write define/it helpers that accept a list of platforms to include/exclude so

[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...

2014-08-14 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/41 Add missing test, skip some specs on wp Added in a few things that were added to mobile-spec after tests were initially ported: -new find method spec -specs which