Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115#issuecomment-204604763
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115#discussion_r58141872
--- Diff: tests/tests.js ---
@@ -51,14 +48,14 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 3;
var
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115#discussion_r58141525
--- Diff: tests/tests.js ---
@@ -51,14 +48,14 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 3;
var HIG
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115
Changes to stop using global object - remove all created contacts from the
emulator
Issues Addressed:
1. Removing Global gContactObj
2. Clean up all the contacts cr
