[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-06 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206509564 Lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-06 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206471960 @sarangan12 errors fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206034479 @omefire I am ok with removing the logging. Please check the travis erros. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206015404 @omefire why are you removing this? This was actually pretty useful in debugging --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206014203 @sarangan12 could you please review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-plugin-contacts pull request: Remove logging

2016-04-05 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/117 Remove logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-plugin-contacts RemoveLogging Alternatively you