[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-219870484 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/70/commits/1d923

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-161005865 Can you guys create an issue on your Jira with this info so we close this PR. Because is actually a MAJOR issue --- If your project is set up for it

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151176788 Is there a JIRA issue related to this pull request. We need to be able to see what the problem is before we can talk about this issue. We're not going

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151138324 I'm not android SME, maybe @macdonst can take a look. My general comment on this PR, is that if you don't know what are not sure what's the r

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-149231952 The idea is for someone who has more knowledge of android to erase this op along with the comment and merge it --- If your project is set up for it, you

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132743916 I dont know enough android either to fix it, all I know is that the op I comment out is the one making trouble. I think that the ops means to do

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132742487 Commenting out code is never the solution. This file appears to desperately need a refactor anyway. I don't know enough about the android

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132692263 Someone please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-125333148 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Remove ops

GitHub user manugb opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/70 Remove ops I made an isolate project that only handles this plugin. And when I modify an existing contact and print the rows of cursor in line 272 I got like 1000 more rows.