Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-motion/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-126129030
I agree. My goal here however was just to fix the exception, not change the
behavior of a plugin I'm not familiar with :smile:... So what's the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-126136377
Yeah. Merge as is to side step the error.
I'll create jira tickets and revisit later.
---
If your project is set up for it, you can
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125955137
The PR LGTM.
However, IMO the code that emits `devicemotion` events might be removed due
to:
a) this is not a scope of
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125975741
Yeah. I was still going to look at a rewrite in the near future. No need to
fake data...
On Jul 29, 2015, at 6:38 AM,
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125794448
Yeah, I have just been wondering the same thing. The only `browser`
specific thing is that it starts firing the `devicemotion` event when you
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125793282
Actually, on second thought ...
I don't think there is much reason for the browser implementation to have
it's own version of
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33
CB-9426 Fix exception using device motion plugin on browser platform
The plugin's `plugin.xml` defines a general `js-module` with the name
`accelerometer`. It defines another
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125805744
Ok, I've deleted the browser specific implementation and moved the browser
specific logic into the general implementation, and also added some
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125791006
@stevengill and @purplecabbage - interested in whether this fix looks right
to you guys, since I've not worked in this code much before.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125792526
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
11 matches
Mail list logo
