Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150849472
Haha we were just chatting about this yesterday. Makes most sense to add
the dependency to tests/plugin.xml
---
If your project is set up for it, you
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150835775
Love it!
Shockingly, @stevengill and I had this idea also.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150781035
@purplecabbage what if we add device dependency not to accelerometer plugin
itself but to tests/plugin.xml ?
---
If your project is set up for it, you
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150621997
Yes. Except it is only useful for plugins that depends on device.
Accelerometer should not depend on device. I would like to move this directly
into
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150563793
@nikhilkh this is essentially what I needed so I will use this to pend
unsupported tests on iOS simulator
I guess this will add a cordova-plugin-devi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150561368
@alsorokin Isn't this what you needed for disabling failing tests on iOS
simulator?
---
If your project is set up for it, you can reply to this email an
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150308646
Works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150307876
Created an issue for this here: CB-9847
Moving forward with `isVirtual`
---
If your project is set up for it, you can reply to this email and ha
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119817738
device.isVirtual +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119817528
Ah, gotcha.
I actually think I like isVirtual better as it sidesteps all the sim/emu
discussions.
I'll let this pr sit for a bit and see i
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119813107
Heh, I wasn't wanting to start a semantics argument, just after consistency.
My understanding is that the usual terminology is "simulator" for iO
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119811586
2 other 'offers'
device.isVirtual
Or the opposite
device.isDevice
---
If your project is set up for it, you can reply to this em
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119809686
Attempting to avoid a semantics argument, I chose to overlook this.
do we really need to add 2 properties? iOS simulator IS a simulator.
---
I
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119804386
Should this be "Emulator" rather than "Simulator" (that's the terminology
used elsewhere in Cordova, isn't it? And the typical terminology for Android
a
GitHub user AndyChenW opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/35
add isSimulator for iOS & Android device
@purplecabbage change pr and property name to isSimulator.
You can merge this pull request into a Git repository by running:
$ git pull
16 matches
Mail list logo
