[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-14 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 +1 to deprecation as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 +1 to @jcesarmobile's proposed solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Yeah, so the solution should be to deprecate `trustAllHosts`, documenting it and then remove those methods, not to implement them with a safe implementation because that

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread amovsesy
Github user amovsesy commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 @jcesarmobile, I understand, but this is violating Google's play ToS and it clearly states that any new updates or apps using an unsafe implementation of TrustManager will be

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Those methods are there to ignore the certificates if you pass `trustAllHosts` param set to true (default is false) --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Cordova CI Build has completed successfully. **Commit** -