[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread aroberson
Github user aroberson closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread aroberson
Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#issuecomment-112255281 Duke, I did not do that on purpose as I wanted to keep it as close to possible to the original functionality. I can make the change.

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#issuecomment-112243188 Is 'withCredentials' available everywhere? I think this has potentially wider impact than just the cordova-browser platform. Shouldn't we

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread dukex
Github user dukex commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#discussion_r32469454 --- Diff: www/browser/FileTransfer.js --- @@ -231,7 +236,9 @@ FileTransfer.prototype.download = function(source, target, successCallback,

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread dukex
Github user dukex commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#discussion_r32469314 --- Diff: www/browser/FileTransfer.js --- @@ -121,6 +122,9 @@ FileTransfer.prototype.upload = function(filePath, server, successCallback,

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread aroberson
GitHub user aroberson opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88 Add Browser support for using Cookies Added a property for browser to set the withCredentials flag on the XMLHttpRequest for upload and download You can merge this pull requ