[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-06-08 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-110114815 @machenmusik, I definitely see the CLA now -- thanks! And it's merged -- if there are any issues with it, please keep the bug at [CB-6503](http

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-06-06 Thread ms88privat
Github user ms88privat commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-109704709 @clelland can you please merge it now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-04-30 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-98015897 thought I did the ICLA a long while back... anyway, did it again --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-04-29 Thread riaan53
Github user riaan53 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-97330361 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-04-28 Thread visum
Github user visum commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-97146581 Bump. I'm in need of this as well. We still just waiting on @machenmusik to file an ICLA? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-02-05 Thread LanceEa
Github user LanceEa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-73067401 I'm trying to upload some images to Azure Blob Storage and it doesn't seem to like the multipart-form. I would like to be able to upload using "imag

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-12-19 Thread ianjosephwilson
Github user ianjosephwilson commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-67674326 I just needed this for the Amazon S3 rest upload. Did something like this PR already get integrated? --- If your project is set up for it,

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-07-25 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-50159977 Bump! @machenmusik -- we just need an ICLA filed, and we can pull this code in. Thanks --- If your project is set up for it, you can rep

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-06-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-47416739 @machenmusik, do you have an ICLA on file with the Apache foundation? I've reviewed this, and it looks good (other than a couple of minor ni

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-06-27 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r14322195 --- Diff: src/android/FileTransfer.java --- @@ -315,8 +315,13 @@ public void run() { // Use a post method

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-06-27 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r14322193 --- Diff: src/amazon/FileTransfer.java --- @@ -315,8 +315,12 @@ public void run() { // Use a post method.

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41205346 I was expecting for example that it would actually include the (more descriptive) JIRA issue title if I just said CB-6503 to avoid useless cut

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204431 Actually, I was correct. When you edited the title to include the issue id, and then commented, see what happened: https://issues.apache.org/jira/br

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204117 Thanks! Appreciate your contrib and you filing the issue. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204151 Thanks. The automagical link is just when the pull request is merged into master, the jira issue gets updated with the commit.

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41203933 @jesse was able to edit out the version change here. @shazron done but manually, no automagical linking detected :-/ --- If your project is