[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-164065701 Ah, gotcha. Thanks for the explanation. If the tests pass, then it LGTM! --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-10 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-163852420 This fixes the manual test for camera plugin when [DATA_URI output is selected](https://github.com/apache/cordova-plugin-camera/blob/e1911a3c78592a

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-10 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-163736130 Thanks for documenting! What I mean is: is this a supported feature in the first place? --- If your project is set up for it, you can reply to t

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-163520007 Updated the docs, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#discussion_r47194431 --- Diff: src/windows/FileTransferProxy.js --- @@ -89,19 +179,141 @@ exec(win, fail, 'FileTransfer', 'upload', var isMultip

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#issuecomment-163464535 Are base64-encoded files documented as supported by the file transfer API? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122#discussion_r47181683 --- Diff: src/windows/FileTransferProxy.js --- @@ -89,19 +179,141 @@ exec(win, fail, 'FileTransfer', 'upload', var isMulti

[GitHub] cordova-plugin-file-transfer pull request: CB-9837 Add data URI su...

2015-12-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/122 CB-9837 Add data URI support to file-transfer upload on iOS Adds iOS and Windows implementation Adds corresponding tests [Jira issue](https://issues.apache.org/jira