[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread torrmal
Github user torrmal commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38857287 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38834100 I've squashed the two commits together, and merged that into the dev branch now -- feel free to close this pull request if GitHub doesn't do it aut

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38820556 That last patch looks like it did the trick -- there is still one test failing (filetransfer.spec.9), but it appears to have been failing for a whil

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38819465 We run all of the automated tests from the [Mobile Spec application](https://github.com/apache/cordova-mobile-spec/) -- it's a Cordova app that exe

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread torrmal
Github user torrmal commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38818105 Hi Ian, My apologies, I a very sorry about this. how do I run the tests? I think I found where the error is, when aboirt is cal

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38811807 I've incorporated your code into my local repository, but it looks like FileTransfer.abort() is no longer working correctly. There are three mobile

Re: [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread Ian Clelland
You can send a signed copy (either physically signed, or cryptographically) to secret...@apache.org. http://www.apache.org/licenses/#clas has the complete instructions. Ian On Wed, Mar 26, 2014 at 4:02 PM, Jorge Torres < jorge.torres.maldon...@gmail.com> wrote: > Hi Ian, > > Who do I send my I

Re: [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread Jorge Torres
Hi Ian, Who do I send my ICLA? Thank you, Jorge On Wed, Mar 26, 2014 at 12:19 PM, clelland wrote: > Github user clelland commented on the pull request: > > > https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38704767 > > This looks like it should be part of the

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38704767 This looks like it should be part of the work for [CB-5175](https://issues.apache.org/jira/browse/CB-5175). Thanks for the patch, Jorge --

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread torrmal
GitHub user torrmal opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24 Update CDVFileTransfer.m Since download can take time, for it to be non-blocking, moved the call to a separate thread. You can merge this pull request into a Git repository by