[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user Mikejo5000 closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-221373959 Merged in https://github.com/apache/cordova-plugin-file-transfer/commit/82c5af9b5dd6accbd6b2d25174d3c1f4e576e5b3 @Mikejo5000 could you please c

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-221342831 @daserge Thanks for your review - can you make the improvements you suggest and help merge this in. --- If your project is set up for it, you ca

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#discussion_r64423473 --- Diff: README.md --- @@ -315,3 +319,253 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-221322800 LGTM, minor comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#discussion_r64423218 --- Diff: README.md --- @@ -315,3 +319,253 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-221028953 @daserge Can you please review and help merge? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-219924763 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/145/c

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-217924472 Sounds like there is a conflict with master - @Mikejo5001 Could you please rebase? Your diff should only contain the line you added. --- If your

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-217923056 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer pull request: added link to sample

GitHub user Mikejo5000 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/145 added link to sample You can merge this pull request into a Git repository by running: $ git pull https://github.com/Mikejo5000/cordova-plugin-file-transfer master Al