Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708869
Moved `isChrome` to be browser specific (we only ever call it either from
browser specific code, or after verifying we're running on browser platform).
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708771
@omefire - no, I don't think so. I think feature detection is more
appropriate for the intent of this code. Also, my goal wasn't to change the
existing l
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162621624
Would it not be better to use the useragent to detect if the browser we're
dealing with is chrome ?
---
If your project is set up for it, you can reply to
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46821107
--- Diff: www/isChrome.js ---
@@ -0,0 +1,26 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46792384
--- Diff: www/isChrome.js ---
@@ -0,0 +1,26 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162436942
Looks good to me :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162383919
Hey @stevengill, could you take a look at this? I just want to verify this
doesn't do anything to screw with `uglify` (which is the change that I am
modi
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/152
CB-10023 Fix "proxy not found error" on Chrome.
We shouldn't be patching `requestFileSystem` and `resolveLocalFileSystem`
on Chrome. Recent change broke the existing logic for this.