[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214543607 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60991619 --- Diff: README.md --- @@ -273,6 +273,15 @@ Listing asset directories is really slow on Android. You can speed it up though, adding `src/a

[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60990249 --- Diff: README.md --- @@ -273,6 +273,15 @@ Listing asset directories is really slow on Android. You can speed it up though, adding `src/an

[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60988953 --- Diff: README.md --- @@ -273,6 +273,15 @@ Listing asset directories is really slow on Android. You can speed it up though, adding `src/an

[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214520604 @riknoll, @jasongin : Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-plugin-file pull request: CB-11142: Fix the NeedPermission...

2016-04-25 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-file/pull/179 CB-11142: Fix the NeedPermission code for the case when external medi… …a is not mounted in Android You can merge this pull request into a Git repository by running: $ git pul