[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
GitHub user dzeims opened a pull request: https://github.com/apache/cordova-plugin-file/pull/52 CB-6940: Android: context.getExternal* methods return null if sdcard isn't in mou... ...nted state, causing exceptions that prevent startup from reaching readystate You can merge this

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
Github user dzeims commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46218127 I've updated the try/catch blocks and wrapped them with an Environment.getExternalStorageState() check I noticed was being used in FileUtils. From what I

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
Github user dzeims commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46221077 My mistake, it should be NullPointerException. Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46241179 I've accepted the first two and did the last fix at the same time. Can you close this pull request, since I don't remember how Apache wants us to do this.

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
Github user dzeims closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the