Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153929493
Done! Thanks ghenry22 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153926046
once merged you could also close out PR #121 as duplicate as it attempts to
solve the same issue but generates absolute paths from c:\... which are not
us
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153925057
MS docs confirm the same, should be ms-appx:///
Committing an update to fix now.
reference:
https://msdn.microsoft.com/en-us/library/
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153923917
CB-9020 does say they are targeting WP 8.1 which uses the new windows
platform so this PR would also resolve CB-9020.
CB8257 seems to refer specif
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153923115
Sorry I mistyped... I meant to refer to CB-9020 not CB-9090.
I was thinking CB-8257 was referring to WP 8.1 (which uses the 'windows'
platform for plug
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153922252
CB-9090 is for the whitelist plugin
CB-8257 is the same issue but for the wp8 platform. This fix is for the
windows platform, I don't have native code
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#discussion_r43965498
--- Diff: src/windows/FileProxy.js ---
@@ -168,6 +168,15 @@ WinFS.prototype.__format__ = function(fullPath) {
return 'cdvfile://localhos
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153920849
It looks like CB-9090 and CB-8257 are about exactly the same problem as
this CB-9887.
---
If your project is set up for it, you can reply to this email a
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153536161
@purplecabbage yep I have signed an ICLA and have already had a PR merged
into the file plugin.
I'll send you a direct message on slack with full
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153511867
Hi @ghenry22 !
This looks good, as do your other prs. Have you signed an iCLA? [1]
It is hard to tell because you do not have your name on yo
Github user arangas commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153221198
I see, I wasn't aware of that! I've tested this and looks good, cheers. It
would be great to get this merged.
---
If your project is set up for it, you ca
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219744
added applicationStorageDirectory to defined paths and updated readme with
relevant comments for this path.
---
If your project is set up for it, you can
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153219294
my understanding is that applicationStorageDirectory is a bit redundant.
It is the same as the applicationDirectory but has a note that you can change
to
Github user arangas commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-152005214
I've tested and examined this and it looks great, thanks! Is there any
reason not to define applicationStorageDirectory and set it to the same value
as dat
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/143
CB-9887 cordova.file.* paths for windows platform
Update the plugin to define cordova.file.* paths for windows platform as
appropriate.
Documentation updated to show where to
16 matches
Mail list logo
